Fix(GraphQL): Fix Execution Trace for Add and Update Mutations #7656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
abhimanyusinghgaur
approved these changes
Mar 26, 2021
vmrajas
added a commit
that referenced
this pull request
Mar 26, 2021
* Remove unused function * Add tracing for existence query execution * Fix tests (cherry picked from commit ba8f5da)
vmrajas
added a commit
that referenced
this pull request
Mar 26, 2021
aman-bansal
pushed a commit
that referenced
this pull request
Apr 8, 2021
* Remove unused function * Add tracing for existence query execution * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
After the recent refactor of Mutation Rewriting, now there is an extra execution of existenceQuery made in case of Add and Update Mutations. These also need to be accounted for in Execution Trace. This PR accomplishes this. It also makes a minor refactoring of a function in mutation_rewriter.go
Testing:
Existing Unit and e2e tests. No tests added.
Fixes GRAPHQL-1129
This change is